This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
Conversation
Removes a condition where static options are not added as part of render function when multiple attribute is enabled Closes angular#4325
Contributor
|
This looks like the right fix to me but I can't think how to create a unit test for it. |
Contributor
Author
|
@petebacondarwin - I give 👍 to merge this PR if its OK with you. |
Contributor
|
@siddii - thanks for this PR. I added an E2E test that actually fails without the fix and included a warning in the console if one attempts to load more than one copy of angular. |
|
@siddii @petebacondarwin great to see such a clean solution to this bug. I should start digging in the source myself at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #5587
I am not sure where to write the test for this fix (may be
e2ewith html file loading build/angular.js?) .Here is a plunkr showing that the fix works - http://plnkr.co/edit/xey09HDiX5jQmHKbgEVi?p=preview